[Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled

Bernd Kuhls bernd.kuhls at t-online.de
Mon Sep 5 20:20:25 UTC 2016


Am Mon, 05 Sep 2016 22:05:40 +0200 schrieb Thomas Petazzoni:

> Hello,
> 
> On Mon,  5 Sep 2016 16:51:19 +0200, Bernd Kuhls wrote:
>> Fixes
>> http://autobuild.buildroot.net/results/c32/
c32a21240a9933796ee850349a62ff3c2314f25c/
>> http://autobuild.buildroot.net/
results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/
>> 
>> Signed-off-by: Bernd Kuhls
>> <bernd.kuhls at t-online.de>
>> ---
>>  package/ffmpeg/ffmpeg.mk | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk index
>> a90d437..74f783c 100644 --- a/package/ffmpeg/ffmpeg.mk +++
>> b/package/ffmpeg/ffmpeg.mk @@ -250,7 +250,8 @@ endif
>>  
>>  # To avoid a circular dependency only use opencv if opencv itself does
>>  # not depend on ffmpeg.
>> -ifeq
>> ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x
$(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx)
>> +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled +ifeq
>> ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x
$(BR2_ARM_ENABLE_VFP),yxx)
> 
> I'm not really happy with this fix. When you're using OpenCV/FFmpeg on
> ARM, you definitely want to be able to use the VFP. So I'd prefer to see
> the problem fixed rather than having this combination disabled.
> 
> Thomas

Hi Thomas,

my coding skill are insufficient to fix the problem so I marked my patch 
as rejected. I tried to compare the ARM_ROUND_DBL function in both 
opencv2 and opencv3 but the structure of the includes has changed so I 
was unable to spot the fix which provides working vfp support in opencv3.

Regards, Bernd



More information about the buildroot mailing list