[Buildroot] [PATCH 06/11] perl: use $(TARGET_MAKE_ENV) when calling $(MAKE)

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Oct 29 13:57:09 UTC 2016


Hello,

On Fri, 28 Oct 2016 10:18:24 -0300, gustavo.zacarias at free-electrons.com
wrote:
> From: Gustavo Zacarias <gustavo.zacarias at free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias at free-electrons.com>
> ---
>  package/perl/perl.mk | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/perl/perl.mk b/package/perl/perl.mk
> index a8768b2..b19fa78 100644
> --- a/package/perl/perl.mk
> +++ b/package/perl/perl.mk
> @@ -81,20 +81,21 @@ PERL_CONF_OPTS += --only-mod=$(subst $(space),$(comma),$(PERL_MODULES))
>  endif
>  
>  define PERL_CONFIGURE_CMDS
> -	(cd $(@D); HOSTCC='$(HOSTCC_NOCCACHE)' ./configure $(PERL_CONF_OPTS))
> +	(cd $(@D); HOSTCC='$(HOSTCC_NOCCACHE)' $(TARGET_MAKE_ENV) \

I think it makes more sense to have $(TARGET_MAKE_ENV) before HOSTCC=,
since HOSTCC= is package-specific, and should therefore appear after
the more "global" TARGET_MAKE_ENV variable.

I did the same change in patch 07/11 for the host variant of perl.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list