[Buildroot] [PATCHv2] toolchain/external: fix arch-subdir

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Oct 28 12:40:59 UTC 2016


Hello,

On Thu, 27 Oct 2016 20:01:48 +0200, Yann E. MORIN wrote:

> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index f7c6a19..770a50f 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -665,7 +665,7 @@ define TOOLCHAIN_EXTERNAL_INSTALL_SYSROOT_LIBS
>  			SUPPORT_LIB_DIR=`readlink -f $${LIBSTDCPP_A_LOCATION} | sed -r -e 's:libstdc\+\+\.a::'` ; \
>  		fi ; \
>  	fi ; \
> -	ARCH_SUBDIR=`echo $${ARCH_SYSROOT_DIR} | sed -r -e "s:^$${SYSROOT_DIR}(.*)/$$:\1:"` ; \
> +	ARCH_SUBDIR=`echo $${ARCH_SYSROOT_DIR} | sed -r -e "s:^$${SYSROOT_DIR}::; s:/+$$::;` ; \

Unfortunately, this doesn't work:

 1/ There is a missing double quote in your sed expression, so it breaks

 2/ Once fixed, your patch makes sure ARCH_SUBDIR is empty when
    SYSROOT_DIR==ARCH_SYSROOT_DIR but continues to break in the
    side-by-side sysroot case we have with the MIPS toolchains.

So, I've instead use Vicente patch, that I have slightly improved.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list