[Buildroot] [PATCH v2] skeleton: /etc/network/interface.d/* support
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat Oct 22 21:28:31 UTC 2016
Hello,
On Tue, 16 Aug 2016 10:38:28 -0500, Matt Weber wrote:
> diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk
> index 1000161..39e2cbb 100644
> --- a/package/skeleton/skeleton.mk
> +++ b/package/skeleton/skeleton.mk
> @@ -170,9 +170,19 @@ define SKELETON_SET_NETWORK_DHCP
> endef
> endif
>
> +ifeq ($(BR2_PACKAGE_IFUPDOWN),y)
> +define SKELETON_SET_NETWORK_SUPPORT_INTERFACES_D
> + ( \
> + echo ; \
> + echo "source interfaces.d/*"; \
> + ) >> $(TARGET_DIR)/etc/network/interfaces
> +endef
> +endif
> +
> define SKELETON_SET_NETWORK
> mkdir -p $(TARGET_DIR)/etc/network/
> $(SKELETON_SET_NETWORK_LOCALHOST)
> + $(SKELETON_SET_NETWORK_SUPPORT_INTERFACES_D)
> $(SKELETON_SET_NETWORK_DHCP)
> endef
>
> diff --git a/system/device_table.txt b/system/device_table.txt
> index dc1af51..69b1d46 100644
> --- a/system/device_table.txt
> +++ b/system/device_table.txt
> @@ -17,5 +17,6 @@
> /etc/network/if-pre-up.d d 755 0 0 - - - - -
> /etc/network/if-down.d d 755 0 0 - - - - -
> /etc/network/if-post-down.d d 755 0 0 - - - - -
> +/etc/network/interfaces.d d 755 0 0 - - - - -
> # uncomment this to allow starting x as non-root
> #/usr/X11R6/bin/Xfbdev f 4755 0 0 - - - - -
> diff --git a/system/skeleton/etc/network/interfaces.d/.empty b/system/skeleton/etc/network/interfaces.d/.empty
> new file mode 100644
> index 0000000..e69de29
Sorry for the late answer. I believe none of this should go in the main
skeleton, as it is really specific to ifupdown. What about instead
adding the following in ifupdown.mk:
ifeq ($(BR2_ROOTFS_SKELETON_DEFAULT),y)
define IFUPDOWN_TUNE_ETC_NETWORK_INTERFACES
mkdir -p $(TARGET_DIR)/etc/network/interfaces.d
echo "source interfaces.d/*" >> $(TARGET_DIR)/etc/network/interfaces
endef
IFUPDOWN_TARGET_FINALIZE_HOOKS += IFUPDOWN_TUNE_ETC_NETWORK_INTERFACES
endif
define IFUPDOWN_PERMISSIONS
/etc/network/interfaces.d d 755 0 0 - - - - -
endef
This should do exactly the same thing, but is isolated in the ifupdown
package.
Could you look into this?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list