[Buildroot] [PATCH 1/2] X11/odroidc2-driver: New Package.

[daggs]

Greetings Arnout,

> On 17-10-16 23:11, daggs wrote:
> 
> [snip]
> >>  You forgot to select or depend on ODROID_MALI. I think the appropriate approach
> >> is to select it in this case. Then of course you do have to add the reverse
> >> dependencies:
> >> 	depends on BR2_aarch64 || BR2_ARM_EABIHF # odroid-mali
> >> 	depends on BR2_TOOLCHAIN_USES_GLIBC # odroid-mali
> > will do.
> > 
> [snip]
> >>> +comment "xf86-video-odroidc2 needs egl support from odroid-mali and ARM64 arch"
> >>> +	depends on !BR2_PACKAGE_ODROID_MALI || !BR2_aarch64
> >>
> >>  This should become a glibc + NPTL threads comment instead.
> > why? are we sure this won't work for uclibc or musl?
> 
>  Because of the 'select BR2_PACKAGE_ODROID_MALI' you have a dependency on glibc.
you are correct, will fix.

> 
>  Oh, and we don't mention arch dependencies in the comment, so it should be
> 	depend on BR2_aarch64
> 	depends on !BR2_TOOLCHAIN_USES_GLIBC
will fix.

> 
> [snip]
> >>> +XDRIVER_XF86_VIDEO_ODROIDC2_LICENSE_FILES = README.txt 
> >>> +XDRIVER_XF86_VIDEO_ODROIDC2_DEPENDENCIES = \
> >>> +	odroid-mali \
> >>> +	xproto_fontsproto \
> >>> +	xproto_xproto \
> >>
> >>  You also select dri2proto, is that not needed? But actually, I don't see any
> >> inclusion of either of these three proto packages, only of xserver stuff (and a
> >> few that I can't place, like ump.h)
> > ump.h is part of the x11 egl pkg.
> > I've added the above deps based on compilation errors I've got.
> 
>  I suspect that it actually comes from the headers of odroid-mali. If that is
> the case, it would be better to put the dependency in odroid-mali itself
> (conditional on using the X11 version, of course).
I don't understand one thing, the existence of dri2proto does affects odroid-mali, why should I depend odroid-mali dri2proto it when there is no logic to do so?

> 
> >>
> >>> +	mesa3d \
> >>> +	xserver_xorg-server
> >>> +
> >>> +define XDRIVER_XF86_VIDEO_ODROIDC2_INSTALL_CONF_FILE
> >>> +        $(INSTALL) -m 0644 -D $(@D)/src/xorg.conf $(TARGET_DIR)/etc/X11/xorg.conf
> >>
> >>  Hm, not sure about this one. If all packages do that we get conflicts. For e.g.
> >> the Vivante X11 driver, we put in the help text what you have to add to
> >> xorg.conf to make it work.
> > alternatively one can us the turbofb X11 driver to X to work do I based the pkg on that. 
> > can I see the expected result in the Vivante X11 driver?
> 
>  Well, you picked the _only_ driver that installs a xorg.conf... We just haven't
> noticed when Scott Fann contributed that driver.
so the correct driver to base the package on is the Vivante X11 driver?

Dagg.