[Buildroot] [PATCH v11 4/4] core: only remove O from MAKEOVERRIDES

[Samuel Martin]

On Sun, Oct 16, 2016 at 7:48 PM, Arnout Vandecappelle <arnout at mind.be> wrote:
>
>
> On 16-10-16 13:54, Samuel Martin wrote:
>> For no apparent reason, MAKEOVERRIDES is not treated the same way
>> depending on whether O is set or not on the command line:
>> * when O is set on the command line (i.e. out-of-tree build): all
>>   variables were stripped away from MAKEOVERRIDES;
>> * when O is not set on the command line (i.e. in-Buildroot-source-tree
>>   build): all variables are kept and forwarded to the sub-make call.
>>
>> This change cleans things up by only removing the relevant variables
>> from MAKEOVERRIDES when appropriate (i.e. removing O from MAKEOVERRIDES
>> when O is set on the command line) keeping all other variables as-is in the
>> sub-make call; O is set on the sub-make call anyway.
>
>  I'm not sure about this one. Clearing MAKEOVERRIDES makes sure that whatever we
> set on the commandline of Buildroot's make will not get passed down to
> sub-makes. I don't see anything for which it would be useful to pass it down to
> sub-makes as commandline overrides.
>
>  Note that whatever we specify on the command line will be passed down in two
> ways (unless it's overridden by the Makefile, like is done for O): it is passed
> in the environment, and it is passed in MAKEFLAGS in the environment. So even if
> we clear MAKEOVERRIDES, things still get passed down but just in the environment.

Interesting, I did not know that.

>
>  So, I don't see a good reason to apply this patch.

Fair enough.

Regards,


-- 
Samuel