[Buildroot] [PATCH 03/10] core: offload handling of BR2_EXTERNAL into the script

[Thomas Petazzoni]

Hello,

On Sun,  2 Oct 2016 11:09:52 +0200, Yann E. MORIN wrote:

> +$(shell support/scripts/br2-external \
> +	-m \
> +	-o '${BR2_EXTERNAL_FILE}' \
> +	$(BR2_EXTERNAL))

Excessive newline usage here. Also, why ${} instead of $() ?

> +BR2_EXTERNAL_ERROR =
> +include $(BR2_EXTERNAL_FILE)
> +ifneq ($(BR2_EXTERNAL_ERROR),)
> +$(error $(BR2_EXTERNAL_ERROR))
>  endif

I don't really like this BR2_EXTERNAL_ERROR variable that gets written
in the .mk file by the br2-external script if it fails, and then
re-used here. But I'm not sure I have a better proposal.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com