[Buildroot] [PATCH 1/1] package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Nov 24 12:28:59 UTC 2016
Hello,
On Thu, 24 Nov 2016 13:20:13 +0200, Baruch Siach wrote:
> On Thu, Nov 24, 2016 at 04:56:42PM +1100, Sam Bobroff wrote:
> > Fixes next commit d634d9dda7f3c328d63469cb628c79da49a09e89.
> >
> > Signed-off-by: Sam Bobroff <sam.bobroff at au1.ibm.com>
> > ---
> > Baruch,
> >
> > I've rebased the patch onto next, I'm not sure what other changes to
> > make. Does it look OK now? (Will it get squashed in next?)
>
> The Buildroot maintainers do not rebase/amend next. When there is an issue
> with an applied commit, either in next or master, post a but fix patch. Hence
> the commit log should be more detailed. Also, you may mention the commit the
> introduced the bug as you did, but not 'next'. The next branch will soon merge
> into master, but the commit log will not change.
Sam: I thought your initial patch was not a bug fix, but a feature
addition, which is why I applied it to the "next" branch. However, I
see in the autobuilders failures of the host-qemu package for
powerpc64, and I believe those would be fixed by your patch. Could you
confirm it's the case? If it is, then I'll cherry-pick the original
patch (+ this additional fix) into the master branch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list