[Buildroot] [PATCH/next] toolchain-external: support gcc < 4.3

Arnout Vandecappelle arnout at mind.be
Wed Nov 23 23:38:33 UTC 2016



On 23-11-16 23:21, Thomas Petazzoni wrote:
[snip]
>> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
>> index 3991bc1..72e7292 100644
>> --- a/toolchain/helpers.mk
>> +++ b/toolchain/helpers.mk
>> @@ -145,8 +145,7 @@ check_kernel_headers_version = \
>>  check_gcc_version = \
>>  	expected_version="$(strip $2)" ; \
>>  	if [ -z "$${expected_version}" ]; then \
>> -		printf "Internal error, gcc version unknown (no GCC_AT_LEAST_X_Y selected)\n"; \
>> -		exit 1 ; \
>> +		exit 0 ; \
> 
> Why?

 As stated in the commit log:

When [BR2_TOOLCHAIN_GCC_AT_LEAST] is
empty, we don't do a version check at all in check_gcc_version.

 Perhaps I should add to that "(previously we errored out)".

 Regards,
 Arnout



> 
> Assuming you will respin, I've marked this one as Changes Requested.
> 
> Thanks!
> 
> Thomas
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list