[Buildroot] [PATCH v7] kodi: allow enablement of libamcodec as codec if selected

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Nov 9 21:49:30 UTC 2016


Hello,

On Wed,  9 Nov 2016 21:07:33 +0200, Dagg Stompler wrote:
> allow usage of amcodec if kodi is built and libamcodec is selected
> 
> Signed-off-by: Dagg Stompler <daggs at gmx.com>

I've applied to next, but it would be really really good if you could
review your own patches before sending them. There was an obvious big
mistake in your patch, see below.


> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index e0361da..f9d1a11 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -96,9 +96,9 @@ endif
>  ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
>  KODI_DEPENDENCIES += rpi-userland
>  KODI_CONF_OPTS += --with-platform=raspberry-pi --enable-player=omxplayer
> -KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
> -	-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux" \
> -	LIBS="-lvcos -lvchostif"
> +-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads \
> +-I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux

How do you expect those two lines to work? You don't even tell make
that this value should be assigned to the KODI_INCLUDES variable.
Clearly you didn't review your patch carefully enough here.

> +KODI_LIBS="-lvcos -lvchostif"

Space before/after the = sign, and double quotes not needed.

> +KODI_CONF_ENV += \
> +INCLUDES="$(KODI_INCLUDES)" \
> +LIBS="$(KODI_LIBS)"

The values should have been indented with on tab.

Applied with those issues fixed. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list