[Buildroot] [PATCH 2/6] package/pseudo: enforce the host bitness

Arnout Vandecappelle arnout at mind.be
Tue Nov 8 20:54:56 UTC 2016



On 08-11-16 18:29, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2016-11-07 23:16 +0100, Arnout Vandecappelle spake thusly:
>>
>>
>> On 07-11-16 22:23, Yann E. MORIN wrote:
>>> pseudo can detect the host bitness, but is not sure about it: it checks
>>> what type of file /bin/sh is, using file(1).
>>>
>>> However, in some conditions, /bin/sh can be of a different bitness than
>>> the rest of the system (weird, but not impossible), which causes build
>>> issues.
>>>
>>> Just enforce the bitness, so that pseudo needs not (wrongly) guess it.
>>>
>>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>>> Cc: Gaël PORTAY <gael.portay at savoirfairelinux.com>
>>> Cc: Patrick Keroulas <patrick.keroulas at savoirfairelinux.com>
>>> Cc: Erico Nunes <nunes.erico at gmail.com>
>>> Cc: Julien BOIBESSOT <julien.boibessot at free.fr>
>>> ---
>>>  package/pseudo/pseudo.mk | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/package/pseudo/pseudo.mk b/package/pseudo/pseudo.mk
>>> index 67538a6..3b0ba86 100644
>>> --- a/package/pseudo/pseudo.mk
>>> +++ b/package/pseudo/pseudo.mk
>>> @@ -17,6 +17,7 @@ HOST_PSEUDO_DEPENDENCIES = host-attr host-sqlite
>>>  # configure script is not generated by autoconf, so passing --libdir
>>>  # is necessary, even if the infrastructure passes --prefix already.
>>>  HOST_PSEUDO_CONF_OPTS = \
>>> +	--bits=$(HOSTARCH_BITS) \
>>
>>  I would be just as happy with
>> 	--bits=$(if $(filter %64,$(HOSTARCH)),32,64)
> 
> Yep, that's nice. Except it's reversed, isn't it? I.e. if we find '64'
> in HOSTARCH, then we want to use '64', not '32', right? So:
> 
>     --bits=$(if $(filter %64,$(HOSTARCH)),64,32)

 Ugh, yes, of course, I had filter-out in my head for some reason. Ah, no, it's
because the condition in patch 1/6 was reversed that I was confused.

 Regards,
 Arnout

> 
> (Unless I missed something...)
> 
> Regards,
> Yann E. MORIN.
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list