[Buildroot] [PATCH 1/2] makedevs: resync device creation with upstream busybox

Fabio Estevam festevam at gmail.com
Sat Nov 5 15:03:26 UTC 2016


On Sat, Nov 5, 2016 at 11:38 AM, Arnout Vandecappelle (Essensium/Mind)
<arnout at mind.be> wrote:
> In upstream busbyox, the code to create devices has been simplified:
> the code for a single and for multiple devices is no longer duplicated.
>
> Since we are going to change the device creation code next, it's
> convenient to have only one copy to modify.
>
> There are two behavioural changes with this, but they were introduced
> silently together with other commits in upstream busybox.
>
> - When mknod() fails, the chmod was still done. This is pointless so it
>   is no longer done now.
>
> - There was a check for mode != -1; however, a mode of -1 would not
>   have worked anyway because all bits would be set for mknod(), which
>   would fail. So this check is redundant.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

Tested-by: Fabio Estevam <festevam at gmail.com>


More information about the buildroot mailing list