[Buildroot] [PATCH 1/2] core: don't reset MAKEOVERRIDES when re-entering make

[Maxime Hadjinlian]

Tested-by: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>

On Thu, Nov 3, 2016 at 8:48 AM, Samuel Martin <s.martin49 at gmail.com> wrote:
> On Thu, Nov 3, 2016 at 2:55 AM, Arnout Vandecappelle (Essensium/Mind)
> <arnout at mind.be> wrote:
>> We reset MAKEOVERRIDES to avoid passing down variables that are
>> overridden on the command line to the package build systems. Indeed,
>> the variables overridden on the command line will be Buildroot
>> variables and not relevant to the package build system. In particular
>> the O option is used by some packages and the value passed in on the
>> command line is plain wrong for the individual package.
>>
>> However, in commit 916e614b, MAKEOVERRIDES was moved earlier and it
>> was reset _before_ re-entering make in the cases when something has
>> to be fixed up (incorrect umask, non-absolute paths in O or CURDIR).
>> Therefore, if make is re-entered, any command line overrides are lost.
>>
>> This particularly bites the autobuilders, because they use
>> O=<relative path> to specify the output directory, and they add
>> BR2_JLEVEL=... to avoid starting too many jobs in parallel. The
>> BR2_JLEVEL override is lost.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>> Cc: Samuel Martin <s.martin49 at gmail.com>
>> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
>> ---
>> I have a little worry, because there are two other places where we re-
>> enter top-level make and those are not handled: silentoldconfig and
>> external-deps. BR2_JLEVEL is not relevant for those, but other command-
>> line overridden options may be. However, this hasn't changed from before
>> commit 916e614b so I guess it's OK.
>
>
> Reviewed-by: Samuel Martin <s.martin49 at gmail.com>
>
> Regards,
>
> --
> Samuel
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot