[Buildroot] [PATCH] package/xen: fix build failure on x86 after bump to 47

Yann E. MORIN yann.morin.1998 at free.fr
Tue Nov 1 08:37:01 UTC 2016


Alistair, All,

On 2016-10-31 17:42 -0700, Alistair Francis spake thusly:
> On Mon, Oct 31, 2016 at 3:06 PM, Alistair Francis
> <alistair.francis at xilinx.com> wrote:
> > On Sat, Oct 29, 2016 at 11:27 AM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> >> Alistair, All,
> >>
> >> On 2016-10-29 16:43 +0200, Yann E. MORIN spake thusly:
> >>> Since the bump to 4.7, Xen fails to build because of a double definition
> >>> of __OBJECT_FILE__. This is due to (who would have guessed) the weirdness
> >>> of their buildsystem.
> >>>
> >>> Fix that with a dirty hack: undefine the macro before defining it.
> >>>
> >>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> >>> Cc: Alistair Francis <alistair.francis at xilinx.com>
> >>>
> >>> ---
> >>> Note: totally untested.
> >>
> >> Now build-tested, the double-definition issue is fixed, and the build
> >> succeeds with this defconfig:
> >>
> >>     BR2_aarch64=y
> >>     BR2_TOOLCHAIN_EXTERNAL=y
> >>     BR2_PACKAGE_XEN=y
> >>     BR2_PACKAGE_XEN_HYPERVISOR=y
> >>     BR2_PACKAGE_XEN_TOOLS=y
> >>
> >> Not booted, I don't know Xen enough to test...
> >
> > The patch looks good to me!
> >
> > I just did a build test as well and it works, running a boot test now.
> 
> Tested on ARMv7 (little endian) boot.
> 
> Tested-by: Alistair Francis <alistair.francis at xilinx.com>
> Reviewed-by: Alistair Francis <alistair.francis at xilinx.com>

OK, thanks for the testing! I'll resend the patch officially now (it was
not in patchwork).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list