[Buildroot] [PATCH v2] package/net-tools: fix static linking issue with lintl

Romain Naour romain.naour at gmail.com
Tue May 31 21:02:51 UTC 2016


Hi Peter,

> 
>> @@ -37,7 +35,9 @@ NET_TOOLS_POST_CONFIGURE_HOOKS += NET_TOOLS_ENABLE_I18N NET_TOOLS_ENABLE_IPV6
>  
>  >  define NET_TOOLS_BUILD_CMDS
>  >  	$(TARGET_MAKE_ENV) AR="$(TARGET_AR)" CC="$(TARGET_CC)" \
>  > -		LDFLAGS="$(NET_TOOLS_LDFLAGS)" $(MAKE) -C $(@D)
>  > +		LDFLAGS="$(TARGET_LDFLAGS)" \
>  > +		LIBS="$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)" \
>  > +		$(MAKE) -C $(@D)
> 
> Seperate from this patch, but can't we use TARGET_CONFIGURE_OPTS here
> instead of passing AR/CC/LDFLAGS separately?
> 

Yes, you're right.

Using TARGET_CONFIGURE_OPTS allow to remove TARGET_MAKE_ENV since it also brings
PATH=$(BR_PATH).

I'll send a patch.

Best regards,
Romain


More information about the buildroot mailing list