[Buildroot] [PATCH] system: add comment about busybox-show-others
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri May 27 21:10:00 UTC 2016
Hello,
On Fri, 27 May 2016 22:59:24 +0200, Yann E. MORIN wrote:
> What was puzzling me is that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS *appears*
> to be a Busybox option.
>
> Package options should not be selected before ensurign that the package
> itself is enabled, so we have wither:
>
> select BR2_PACKAGE_FOO
> select BR2_PACKAGE_FOO_OPTION
>
> or:
>
> depends on BR2_PACKAGE_FOO
> select BR2_PACKAGE_FOO_OPTION
>
> or:
>
> select BR2_PACKAGE_FOO_OPTION if BR2_PACKAGE_FOO
>
> However, for this specific option, it is *also* available when Busybox
> is *not* enabled: it is not a package option.
>
> So it is perfectly legit to select it without checking that Busybix
> itself is enabled.
Then change the code to:
select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS if BR2_PACKAGE_BUSYBOX
Indeed, when BR2_PACKAGE_BUSYBOX is disabled,
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is *always* set to 'y'.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list