[Buildroot] [PATCH 16/34] reproducibility/lzo: forbid lzo with reproducible builds
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat May 7 20:25:56 UTC 2016
Hello,
On Sat, 30 Apr 2016 09:49:12 +0200, Gilles Chanteperdrix wrote:
> The lzo archive contains a timestamp.
Missing Signed-off-by line.
> ---
> fs/tar/Config.in | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/fs/tar/Config.in b/fs/tar/Config.in
> index 63663ec..7e4b603 100644
> --- a/fs/tar/Config.in
> +++ b/fs/tar/Config.in
> @@ -33,6 +33,7 @@ config BR2_TARGET_ROOTFS_TAR_LZMA
>
> config BR2_TARGET_ROOTFS_TAR_LZO
> bool "lzo"
> + depends on !BR2_REPRODUCIBLE
> help
> Do compress the tarball with lzop.
>
> @@ -43,6 +44,12 @@ config BR2_TARGET_ROOTFS_TAR_XZ
>
> endchoice
>
> +if BR2_REPRODUCIBLE
> +
> +comment "lzo compression is only available with non-reproducible builds"
> +
> +endif
When we are in such situations, we normally do:
comment "blablabla"
depends on BR2_REPRODUCIBLE
however, in this specific case, I would simply not bother adding a
comment. If we start adding a comment for everything that is not
suitable for reproducible builds, we're going to add hundreds of them I
believe.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list