[Buildroot] [PATCH 04/34] reproducibility: make rootfs.tar reproducible
Arnout Vandecappelle
arnout at mind.be
Sat May 7 19:51:36 UTC 2016
On 05/07/16 15:23, Thomas Petazzoni wrote:
> Hello,
>
> On Sat, 30 Apr 2016 09:49:00 +0200, Gilles Chanteperdrix wrote:
>
>> +define ROOTFS_TAR_CMD
>> + cd $(TARGET_DIR) && { \
>> + find . -\( -! -type d -o -empty -\) -print0 | \
>> + sort -z | \
>> + tar --null -T - -c$(TAR_OPTS)f $@ --mtime=@$(SOURCE_DATE_EPOCH) --numeric-owner; \
>> + }
>
> We normally write such constructs as:
>
> (cd $(TARGET_DIR) && \
> foo ....)
Actually, we don't AFAIK... In general, the parenthesis are not needed so they
should be removed. So also in this case it should be
cd $(TARGET_DIR);
find ....
>
> However, this raises the question of what's needed for all the other
> filesystem formats. Will they all have to implement a different
> ROOTFS_<foo>_CMD variable ? Or will there be some commonalities that
> should be factored out in the common rootfs image infrastructure ?
Yes, to me it makes more sense to do this in the actual target directory after
the post-build scripts have been run.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
More information about the buildroot
mailing list