[Buildroot] [PATCH 1/1] uboot-tools: add missing dependency on host-dtc for the host package

Peter Korsgaard peter at korsgaard.com
Thu May 5 20:17:55 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 >> +HOST_UBOOT_TOOLS_DEPENDENCIES += host-dtc

 > I am not sure I like the idea of having host-uboot-tools always depend
 > on host-dtc, as it adds build time while host-dtc is only needed for
 > some specific use cases of mkimage (generating FIT images).

 > There are really three options I believe:

 >  (1) What you did, i.e have host-dtc as an unconditional dependency of
 >      host-uboot-tools. Everybody pays the price of building host-dtc
 >      even if it's not needed.

 >  (2) Add a sub-option to host-uboot-tools so that people can say "I
 >      need it with FIT image support", which will add host-dtc as a
 >      dependency.

 >  (3) Just do nothing, and let our users be smart enough to realize that
 >      when mkimage complains that dtc is missing, they should enable
 >      host-dtc.

Agreed, it's quite similar to the issues with genimage and
dosfstools. Either option 2 or 3 sounds good to me.

-- 
Venlig hilsen,
Peter Korsgaard 


More information about the buildroot mailing list