[Buildroot] [PATCH 1/1] uboot-tools: add missing dependency on host-dtc for the host package

[Thomas Petazzoni]

Hello,

Thanks for this patch. See my comments below.

On Wed,  4 May 2016 11:38:29 -0300, Carlos Santos wrote:
> The mkimage utility needs dtc when the input is in Flat Image Trees (FIT)
> format. If dtc is not available mkimage fails. Example:
> 
>     $ mkimage -f firmware.its firmware.im
>     sh: dtc: command not found
> 
> Signed-off-by: Carlos Santos <casantos at datacom.ind.br>
> ---
>  package/uboot-tools/Config.in.host | 1 +
>  package/uboot-tools/uboot-tools.mk | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/package/uboot-tools/Config.in.host b/package/uboot-tools/Config.in.host
> index b5a42d9..5c44eaf 100644
> --- a/package/uboot-tools/Config.in.host
> +++ b/package/uboot-tools/Config.in.host
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_HOST_UBOOT_TOOLS
>  	bool "host u-boot tools"
> +	select BR2_PACKAGE_HOST_DTC
>  	help
>  	  Companion tools for Das U-Boot bootloader.
>  
> diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
> index f47b3db..a07fbfa 100644
> --- a/package/uboot-tools/uboot-tools.mk
> +++ b/package/uboot-tools/uboot-tools.mk
> @@ -65,6 +65,8 @@ define UBOOT_TOOLS_INSTALL_TARGET_CMDS
>  	$(UBOOT_TOOLS_INSTALL_DUMPIMAGE)
>  endef
>  
> +HOST_UBOOT_TOOLS_DEPENDENCIES += host-dtc

I am not sure I like the idea of having host-uboot-tools always depend
on host-dtc, as it adds build time while host-dtc is only needed for
some specific use cases of mkimage (generating FIT images).

There are really three options I believe:

 (1) What you did, i.e have host-dtc as an unconditional dependency of
     host-uboot-tools. Everybody pays the price of building host-dtc
     even if it's not needed.

 (2) Add a sub-option to host-uboot-tools so that people can say "I
     need it with FIT image support", which will add host-dtc as a
     dependency.

 (3) Just do nothing, and let our users be smart enough to realize that
     when mkimage complains that dtc is missing, they should enable
     host-dtc.

Arnout, Yann, Peter?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com