[Buildroot] [PATCH] package/libxslt: fix static build

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Mar 29 17:56:51 UTC 2016


Hello,

On Tue, 29 Mar 2016 20:44:53 +0300, Baruch Siach wrote:

> On Tue, Mar 29, 2016 at 02:52:14PM +0200, Thomas Petazzoni wrote:
> > On Tue, 29 Mar 2016 03:01:13 +0200, Thomas Petazzoni wrote:
> > > I've applied because it indeed works, but to be honest, I don't
> > > understand why: I don't quite understand how this can fix the build.
> > > All what this option does is:
> > > 
> > > AC_ARG_WITH(libxml-libs-prefix,
> > >         [  --with-libxml-libs-prefix=[PFX]      Specify location of libxml libs],
> > >         LIBXML_LIBS="-L$withval"
> > > )
> > > 
> > > I.e, it will add -L$(STAGING_DIR)/usr/lib to the gcc options. But that
> > > is completely useless because $(STAGING_DIR)/usr/lib is already the
> > > default search path for libraries. So why does it fix the build? I
> > > don't know.
> > 
> > Baruch has posted another patch that I believe is supposed to fix the
> > same problem: http://patchwork.ozlabs.org/patch/602529/.
> > 
> > Baruch, Jörg, could you have a closer look at this problem, and see
> > which solution, between the one from Jörg and the one from Baruch is
> > actually correct ?
> 
> The libxml2 patch fixes a bug in xml2-config generation. It fixes static build 
> also for raptor, and possibly other libxml2 users (for which libxml2 is only 
> an optional dependency, so we don't see hard failures). So I think that the 
> libxml2 patch should be applied regardless of this one.

Could one of you check if, after the xml2 patch has been applied, the
libxslt fix from Jörg is still needed?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list