[Buildroot] [PATCH v2 1/2] Add SVN repository support for u-boot

Peter Korsgaard peter at korsgaard.com
Fri Mar 25 22:15:57 UTC 2016


>>>>> "Pauli" == Pauli Sundberg <susundberg at gmail.com> writes:

You forgot to add your signed-off-by (git commit -s), so I cannot apply
this. Care to add that (and fix the below) and resend?

 > ---
 >  boot/uboot/Config.in | 9 ++++++---
 >  boot/uboot/uboot.mk  | 4 +++-
 >  2 files changed, 9 insertions(+), 4 deletions(-)

 > diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
 > index 0e79734..5800060 100644
 > --- a/boot/uboot/Config.in
 > +++ b/boot/uboot/Config.in
 > @@ -51,6 +51,9 @@ config BR2_TARGET_UBOOT_CUSTOM_TARBALL
 >  config BR2_TARGET_UBOOT_CUSTOM_GIT
 >  	bool "Custom Git repository"
 
 > +config BR2_TARGET_UBOOT_CUSTOM_SVN
 > +	bool "Custom SVN repository"
 > +
 >  config BR2_TARGET_UBOOT_CUSTOM_HG
 >  	bool "Custom Mercurial repository"

S still comes after H in the alphabet, so please add SVN after
_HG. While we're at it I think we should spell out Subversion instead of
SVN.

Thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list