[Buildroot] [PATCH 1/4] libcap: bump version

Peter Korsgaard peter at korsgaard.com
Wed Mar 16 22:09:32 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > attr is no longer a dependency, not even optional.

 > Refresh our patches, and drop the backport from upstream.

It would have been good to mention something about the new host-gperf
dependency, but ok.
 
 >  define HOST_LIBCAP_BUILD_CMDS
 >  	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)\
 > -		LIBATTR=yes RAISE_SETFCAP=no
 > +		RAISE_SETFCAP=no
 >  endef
 
 >  define HOST_LIBCAP_INSTALL_CMDS
 >  	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
 > -		LIBATTR=yes RAISE_SETFCAP=no prefix=/usr lib=lib install
 > +		RAISE_SETFCAP=no prefix=/usr lib=lib install
 >  endef

Not related to this bump, but this looks wrong. We shouldn't use DESTDIR
/ set prefix to /usr for host builds. From a quick look the prefix is at
least used in libcap.pc, so other host packages will get wrong info if
they use pkgconfig to find host-libcap.

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list