[Buildroot] [Bug 8771] make savedefconfig modifies sources

Peter Korsgaard peter at korsgaard.com
Tue Mar 8 11:36:35 UTC 2016


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 > To be honest, I don't see the difference between in-tree defconfigs,
 > and defconfigs in your BR2_EXTERNAL tree. In both cases, if
 > BR2_DEFCONFIG points to such defconfigs, when you run "make
 > savedefconfig", you will modify version-controlled source code, which
 > IMO isn't nice.

It is a tradeoff. When developing on a project using BR you want to keep
the config under configuration control, and you normally want to commit
minimal (savedefconfig) defconfigs, so making the steps needed to do so
as few as possible is imho a very nice thing.

If on the other hand you are just trying out stuff it doesn't make much
sense (but why are you running make savedefconfig in the first place
then?)

 > I simply believe that:

 >  - It deviates from what the kernel does, which is a bit in violation
 >    of our principle "our configuration system is like the kernel"

True.

 >  - It modifies version-controlled source code.

This can be seen both as a + and a -.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list