[Buildroot] [PATCH 3/3] luaposix: bump to version 33.4.0

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Mar 6 14:48:05 UTC 2016


Dear Francois Perrad,

On Thu,  3 Mar 2016 22:12:46 +0100, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> ---
>  ...round-glibc-_POSIX_PRIORITY_SCHEDULING-bu.patch | 59 ----------------------
>  package/luaposix/Config.in                         | 12 ++---
>  package/luaposix/luaposix.mk                       |  6 +--
>  3 files changed, 7 insertions(+), 70 deletions(-)
>  delete mode 100644 package/luaposix/0001-sched-workaround-glibc-_POSIX_PRIORITY_SCHEDULING-bu.patch

I've applied, but I almost rejected the patch, to be honest. Your patch
does a *lot* more than bumping the version, but your commit log is
empty. Your commit log should have explained why the patch is removed,
and why the ncurses dependency is removed.

I had to go look up for this myself, which is a bit annoying since you
already did this work.

François, this is the 100th time I'm asking you about this: please
*ALWAYS* write a commit log in your patches. *ALWAYS*.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list