[Buildroot] [PATCH 1/1] package/ffmpeg: improve inline asm handling for libpostproc

[Thomas Petazzoni]

Bernd,

On Sun,  6 Mar 2016 12:00:24 +0100, Bernd Kuhls wrote:

>  ifeq ($(BR2_PACKAGE_FFMPEG_POSTPROC),y)
>  FFMPEG_CONF_OPTS += --enable-postproc
> +# disable inline-asm on non-mmx Intel CPUs
> +ifeq ($(BR2_i386)$(BR2_X86_CPU_HAS_MMX),y)
> +FFMPEG_CONF_OPTS += --disable-inline-asm

On x86-64, BR2_i386 is false, but BR2_X86_CPU_HAS_MMX=y, so you will
disable inline-asm. Is this what you want?

Why isn't the condition simply:

ifeq ($(BR2_X86_CPU_HAS_MMX),)
FFMPEG_CONF_OPTS += --disable-inline-asm
endif

Which actually matches your comment: when you have a non-MMX capable
Intel CPU -> disable inline assembly.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com