[Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file.

[Luca Ceresoli]

Hi Nicolas,

On 26/02/2016 11:50, Nicolas Cavallari wrote:
> The default syslog parameters are to keep only 200-400 KiB of logs,
> which is very few if there is a spammy daemon on the system, or a daemon
> that fails and then spams errors that hides the original problem.
> 
> Make S01logging source a /etc/default/logging file where these
> parameters can be overridden.
> 
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari at green-communications.fr>
> ---
>  package/busybox/S01logging | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/busybox/S01logging b/package/busybox/S01logging
> index a72c69d..af7bdff 100644
> --- a/package/busybox/S01logging
> +++ b/package/busybox/S01logging
> @@ -3,10 +3,14 @@
>  # Start logging
>  #
>  
> +SYSLOGD_ARGS=-n
> +KLOGD_ARGS=-n
> +[ -e /etc/default/logging ] && . /etc/default/logging

Instead of '-e', we typically use '-r'.

Other than that, looks good. Could you send v2 with this change?

>  start() {
>  	printf "Starting logging: "
> -	start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n
> -	start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n
> +	start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- $SYSLOGD_ARGS
> +	start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- $KLOGD_ARGS

Unrelated to your patch, but passing '-n' (Run in foreground) looks
strange since we are daemonizing those processes anyway. Do you know any
good reason for this?

-- 
Luca

-- 
Luca