[Buildroot] [PATCH v2] nodm: new package

[Peter Korsgaard]

>>>>> "Ezequiel" == Ezequiel Garcia <ezequiel at vanguardiasur.com.ar> writes:

 > Signed-off-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
 > --
 > Changes from v1:
 >   * Add missing select BR2_PACKAGE_XLIB_LIBX11
 >   * Add upstream URL to Config.in
 >   * Use upstream instead of debian to get the sources.
 >   * Get rid of deprecated NODM_XINIT
 >   * Use /etc/default/nodm.conf
 >   * Cosmetic changes

 >  package/Config.in      |  1 +
 >  package/nodm/Config.in | 15 +++++++++++++++
 >  package/nodm/S90nodm   | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 >  package/nodm/nodm.hash |  2 ++
 >  package/nodm/nodm.mk   | 28 ++++++++++++++++++++++++++++
 >  package/nodm/nodm.pam  | 14 ++++++++++++++
 >  6 files changed, 109 insertions(+)
 >  create mode 100644 package/nodm/Config.in
 >  create mode 100644 package/nodm/S90nodm
 >  create mode 100644 package/nodm/nodm.hash
 >  create mode 100644 package/nodm/nodm.mk
 >  create mode 100644 package/nodm/nodm.pam

 > diff --git a/package/Config.in b/package/Config.in
 > index a2a02a8c5e35..1d28efff7f52 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -307,6 +307,7 @@ comment "X applications"
 >  	source "package/gtkperf/Config.in"
 >  	source "package/leafpad/Config.in"
 >  	source "package/midori/Config.in"
 > +	source "package/nodm/Config.in"
 >  	source "package/pcmanfm/Config.in"
 >  	source "package/qt-webkit-kiosk/Config.in"
 >  	source "package/rdesktop/Config.in"
 > diff --git a/package/nodm/Config.in b/package/nodm/Config.in
 > new file mode 100644
 > index 000000000000..3e71f2dd603d
 > --- /dev/null
 > +++ b/package/nodm/Config.in
 > @@ -0,0 +1,15 @@
 > +config BR2_PACKAGE_NODM
 > +	bool "nodm"
 > +	depends on BR2_PACKAGE_XORG7
 > +	select BR2_PACKAGE_XLIB_LIBX11
 > +	select BR2_PACKAGE_LINUX_PAM

You forgot to propagate the dependencies of linux-pam and the comment
when not available.

There is also an #include <wordexp.h>, and our uClibc config doesn't
support that so it also needs to be disabled for uClibc.


 > +	help
 > +	  nodm is a minimal display manager that simply logs in
 > +	  as a given user and starts an X session, without asking
 > +	  for username or password.
 > +
 > +	  For those cases where automatic login is needed (and
 > +	  does not imply a security issue), nodm is simple to setup,
 > +	  lightweight, and it should do exactly the right thing.
 > +
 > +	  https://github.com/spanezz/nodm/
 > diff --git a/package/nodm/S90nodm b/package/nodm/S90nodm
 > new file mode 100644
 > index 000000000000..a546b3e5d3cf
 > --- /dev/null
 > +++ b/package/nodm/S90nodm
 > @@ -0,0 +1,49 @@
 > +#!/bin/sh
 > +#
 > +# Starts nodm
 > +#
 > +
 > +NODM_FIRST_VT=7
 > +NODM_XSESSION=/etc/X11/Xsession
 > +NODM_OPTIONS=
 > +NODM_X_OPTIONS="-nolisten tcp"
 > +NODM_USER=root
 > +NODM_MIN_SESSION_TIME=60
 > +NODM_X_TIMEOUT=300
 > +
 > +[ -r /etc/default/nodm.conf ] && . /etc/default/nodm.conf

The other /etc/default files don't use the .conf suffix, so I've removed
it here as well.

> +# locally calculated
 > +sha256  840939d27d3d9b02ad09e1cffce24729bcdeee6cea6b3f0037d8ae76b49feecd  0.12-1.tar.gz
 > diff --git a/package/nodm/nodm.mk b/package/nodm/nodm.mk
 > new file mode 100644
 > index 000000000000..246c73e104a8
 > --- /dev/null
 > +++ b/package/nodm/nodm.mk
 > @@ -0,0 +1,28 @@
 > +################################################################################
 > +#
 > +# nodm
 > +#
 > +################################################################################
 > +
 > +NODM_VERSION = 0.12
 > +NODM_SITE = $(call github,spanezz,nodm,debian)
 > +NODM_SOURCE = $(NODM_VERSION)-1.tar.gz

That is not how I suggested on IRC, so I've changed it to:

NODM_VERSION = 0.12-1
NODM_SITE = $(call github,spanezz,nodm,debian/$(NODM_VERSION))
(and no _SOURCE)

That way we don't end up with an anonymous 0.12-1.tar.gz in the
downloads dir / sources mirror.

When building it is hardcoded to use help2man to generate a man page,
which isn't good (people might not have help2man, and it doesn't work
when cross compiling), so I've added a post-patch hook to disable it.

Committed with these fixes, thanks.

-- 
Bye, Peter Korsgaard