[Buildroot] [PATCH 2/5] readline: fix installed libraries permission

Peter Korsgaard peter at korsgaard.com
Tue Jun 14 20:21:23 UTC 2016


>>>>> "Gilles" == Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org> writes:

 > In order to avoid strip failing to strip the library.
 > Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org>

Thanks, but we already have logic in readline.mk to fix this:

ifneq ($(BR2_STATIC_LIBS),y)
# libraries get installed read only, so strip fails
define READLINE_INSTALL_FIXUPS_SHARED
	chmod +w $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*)
endef
READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_FIXUPS_SHARED
endif

So why this patch instead? It would be good if we could get rid of both,
have you tried sending it upstream?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list