[Buildroot] [PATCH] package/middleclass: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jun 7 12:26:56 UTC 2016


Hello,

On Tue, 7 Jun 2016 13:57:20 +0200, Marcin Niestroj wrote:

> > if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS  
> 
> Thanks for pointing it. I used some other package as reference, so I 
> missed that.

Other packages might be wrong, do not hesitate to send patches to fix
them if you find such issues.

> > Could you use the luarocks package infrastructure instead? The
> > middleclass package is available in luarocks, and it greatly simplifies
> > the Lua packages. See the luaexpat package for an example. The
> > Buildroot manual also has extensive documentation about the luarocks
> > package infrastructure.  
> 
> I tried to use luarocks for that package. However I encountered two
> issues with that approach:

OK. François Perrad, who wrote the luarocks package infrastructure, is
in Cc of the discussion. Hopefully he can participate to the discussion
and give some feedback.

> 1) middleclass is not consistent with it's version. In most places it
> is 4.0.0. However in rockspec [1] it defines it's version as 4.0-0. I
> guess it should be 4.0.0-0 instead. This inconsistency needs some
> tweaks in Buildroot package makefile.

Hm, I'm not sure here, François can comment I guess.

> 
> 2) When middleclass is installed with luarocks on my host, it downloads
> *.rockspec directly instead of *.src.rock. I think that Buildroot is
> not supporting that case, but please correct me if I am wrong. It was 
> not straightforward to make it work for me.

Hum, Buildroot does download the .src.rock, since the luarocks package
infrastructure defines:

$(2)_SOURCE             ?= $(1)-$$($(3)_VERSION).src.rock

> Above issues made me unable to add support for middleclass using
> luarocks in a reasonable time. It was much simpler with current
> approach.

Right, but not the most appropriate approach. If the package is on
luarocks.org, it should work with our infrastructure. Let's see what
François can say about this.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list