[Buildroot] [PATCH] linux: provide symlink dtc->linux-dtc is there is no dtc yet

[Arnout Vandecappelle]

On 05/31/16 22:50, Thomas Petazzoni wrote:
> Hello,
> 
> On Fri,  8 Jan 2016 12:30:19 +0100, Thomas De Schampheleire wrote:
>> From: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>>
>> Commit ab74e09eb4e28dab8bed8d783c5f0464d39a32e7 renamed the dtc host tool
>> provided by linux to linux-dtc to avoid clashes with the dtc host tool
>> provided by host-dtc.
>>
>> However, external scripting may well rely on the existence of a device tree
>> compiler as $(HOST_DIR)/usr/bin/dtc, regardless of its source. Changing
>> these external scripts to use linux-dtc means that the scripts need to be
>> aware of the buildroot release they are working with, which is not very
>> nice.
>>
>> Add a symlink dtc->linux-dtc when no $(HOST_DIR)/usr/bin/dtc is present.
>> When host-dtc is not enabled, the end result will be dtc and
>> linux-dtc representing the same thing.
>> When host-dtc is enabled, either it is build before linux and no symlink
>> is created at any time, or it is build after linux, and the 'install'
>> command in host-dtc will overwrite the symlink with a proper dtc. In both
>> cases, the end result will be dtc and linux-dtc representing a different
>> thing.
>>
>> Cc: Peter Korsgaard <peter at korsgaard.com>
>> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> 
> I've applied this patch to next, mainly because Arnout gave his
> Reviewed-by, and because it has been waiting for a loooong time.
> 
> However, I don't quite get why you simply don't include host-dtc in
> your build if you want to be sure to have something in
> $(HOST_DIR)/usr/bin/dtc. We could even push the thing further and not
> installed the Linux DTC at all in $(HOST_DIR) and simply ask people to
> add host-dtc to their build if they need it.

 I could be wrong, but don't we have situations where we really need linux-dtc
and not host-dtc because linux-dtc is patched for e.g. DT overlays?

 Regards,
 Arnout

> 
> But oh well, if we decide to move in this direction, it can be reworked
> later, which is why I've applied.
> 
> Thanks!
> 
> Thomas
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF