[Buildroot] [PATCH v2 2/3] package/protoc-gen-lua: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Jul 20 20:48:07 UTC 2016


Hello,

On Tue, 19 Jul 2016 09:31:12 -0300, Tiago Brusamarello wrote:

> +PROTOC_GEN_LUA_VERSION = v1.1.1
> +PROTOC_GEN_LUA_SITE = $(call github,djungelorm,protobuf-lua,$(PROTOC_GEN_LUA_VERSION))

This has the exact same source as the protobuf-lua package you propose
in PATCH 3/3:

+PROTOBUF_LUA_VERSION = v1.1.1
+PROTOBUF_LUA_SITE = $(call github,djungelorm,protobuf-lua,$(PROTOBUF_LUA_VERSION))

So, we clearly don't want two packages in this case: we want a single
package. The host variant of the package will just install
plugin_pb2.py and protoc-gen-lua like your protoc-gen-lua package is
doing today. And the target package will do what your protobuf-lua
package is doing.

> +define HOST_PROTOC_GEN_LUA_INSTALL_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/protoc-plugin/plugin_pb2.py $(HOST_DIR)/usr/bin
> +	$(INSTALL) -D -m 0755 $(@D)/protoc-plugin/protoc-gen-lua $(HOST_DIR)/usr/bin

Full destination paths please.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list