[Buildroot] [PATCH v7 1/2] boot: add ts4800-mbrboot package

Patrick Keroulas patrick.keroulas at savoirfairelinux.com
Wed Jul 20 13:18:09 UTC 2016


Thomas, Peter and Yann,

Thanks a lot for your time/effort.
Cheers.

--
Patrick Keroulas
Consultant en logiciel libre,
Savoir-faire Linux Inc.

7275 Saint-Urbain, bureau 200
Montréal, Québec H2R 2Y5
tél: (514) 276-5468 ext. 167
fax: (514) 276-5465
_____________________

----- On Jul 15, 2016, at 5:19 PM, Thomas Petazzoni thomas.petazzoni at free-electrons.com wrote:

> Hello,
> 
> I've applied, after doing some minor changes, see below.
> 
> On Fri, 15 Jul 2016 15:23:07 -0400, Patrick Keroulas wrote:
> 
>>  boot/Config.in                        |  1 +
>>  boot/ts4800-mbrboot/Config.in         |  7 +++++++
>>  boot/ts4800-mbrboot/ts4800-mbrboot.mk | 20 ++++++++++++++++++++
> 
> A hash file was missing, so I've added one.
> 
> 
>> +define TS4800_MBRBOOT_INSTALL_TARGET_CMDS
>> +	$(INSTALL) -D -m 0644 $(@D)/mbrboot.bin $(BINARIES_DIR)/mbrboot.bin
>> +endef
> 
> You're installing to $(BINARIES_DIR), not $(TARGET_DIR), so using
> INSTALL_TARGET_CMDS is not correct (it works, but it's not correct).
> 
> I've changed that to use INSTALL_IMAGES_CMDS (and therefore I've also
> added INSTALL_IMAGES = YES).
> 
> Thanks,
> 
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


More information about the buildroot mailing list