[Buildroot] [PATCH v4 2/2] configs: add defconfig for TS-4800

Patrick Keroulas patrick.keroulas at savoirfairelinux.com
Fri Jul 8 16:06:01 UTC 2016


Hello Peter,

Thank you for the review. I've followed every suggestion except two:

----- On Jul 3, 2016, at 11:56 AM, Peter Korsgaard peter at korsgaard.com wrote:
>>>>>> "Patrick" == Patrick Keroulas <patrick.keroulas at savoirfairelinux.com> writes:
>> +++ b/board/technologic/ts4800/genimage.cfg
>> @@ -0,0 +1,37 @@
>> +image boot.vfat {
>> + vfat {
>> + files = {
>> + "zImage",
>> + "imx51-ts4800.dtb"
>> + }
>> + }
>> + size = 8M
>> +}
>> +
>> +image sdcard.img {
>> + hdimage {
>> + }
>> +
>> + partition mbrboot {
>> + in-partition-table = "no"
>> + image = "mbrboot.bin"
>> + offset = 0
>> + }
> 
> Does genimage really handle this correctly (E.G. doesn't overwrite the
> bootloader when it writes the MBR)? I know that we at least postprocess
> the genimage output for odroid2 where a similar boot logic is used
> (board/hardkernel/odroidc2/post-image.sh)

mbrboot.bin size is 238B and genimage writes the partition table @ offset=446 
and the bootloader partition @offset=512. So, nothing should be overwritten.
The output image was fully tested on target.

>> +BR2_PACKAGE_BUSYBOX_WATCHDOG=y
>> +BR2_PACKAGE_FBTERM=y
> 
> Are these _REALLY_ needed for anything?

The tested base board has a touchscreen, but FBTERM is not absolutely
necessary for ts-4800 module and will be removed. 
However, the watchdog is needed because it is enabled by u-boot and
the associated driver is part of the kernel config.

Thank you,

Patrick 




More information about the buildroot mailing list