[Buildroot] [PATCH 03/24 v2] package/skeleton: respect variables namespace
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Jul 5 13:28:30 UTC 2016
Hello,
On Wed, 22 Jun 2016 21:07:25 +0200, Yann E. MORIN wrote:
> In makefiles, variables have global scope. We traditionally ensure that
> we get no name clashing by prefixing all variables with the package
> name.
>
> Currently, this is not the case in the skeleton package, for historical
> reasons (code snippets copied over from the common Makefiles). We
> currently have a mix of naming for the variables:
> - some are indeed prefixed with SKELETON_
> - some are prefixed with SYSTEM_
> - some are prefixed with both
> - some are not prefixed
>
> Clean up these discrepancies, and prefix all variables with just
> SKELETON_ and drop the SYSTEM_ prefix.
>
> Also include SET_ in all variables that do set something (getty) for
> consistency across all the variables.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
> package/skeleton/skeleton.mk | 60 ++++++++++++++++++++++----------------------
> 1 file changed, 30 insertions(+), 30 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list