[Buildroot] [RFC 1/3] zip: add explicit dependencies for host variant

[Julien Floret]

2016-07-02 22:04 GMT+02:00 Arnout Vandecappelle <arnout at mind.be>:
> On 02-07-16 20:48, Julien Floret wrote:
>> Signed-off-by: Julien Floret <julien.floret at 6wind.com>
>> ---
>>  package/zip/zip.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/zip/zip.mk b/package/zip/zip.mk
>> index 5338f881663d..f56ac5a4804d 100644
>> --- a/package/zip/zip.mk
>> +++ b/package/zip/zip.mk
>> @@ -12,6 +12,7 @@ ZIP_LICENSE_FILES = LICENSE
>>
>>  ifeq ($(BR2_PACKAGE_BZIP2),y)
>>  ZIP_DEPENDENCIES += bzip2
>> +HOST_ZIP_DEPENDENCIES += host-bzip2
>
>  Nack. This is another example why the automatic derivation is not good.
> host-zip should either depend on host-bzip2 unconditionally, or never depend on
> it, or depend on it based on BR2_PACKAGE_HOST_BZIP2.
>
>  In this specific case, it should not depend on host-bzip2 IMHO. So the correct
> thing to do with the automatic derivation would be
>
> HOST_ZIP_DEPENDENCIES =

I agree, but the idea of this example was to be isofunctional - to keep the same
dependencies as with auto derivation.
The fix should be done in another patch IMO, probably before this patch.

Julien