[Buildroot] [PATCH v2 08/15] package/gcc: used BR2_TOOLCHAIN_HAS_FORTRAN instead of BR2_TOOLCHAIN_BUILDROOT_FORTRAN

Arnout Vandecappelle arnout at mind.be
Sat Jul 2 11:18:58 UTC 2016


On 01-07-16 23:06, Thomas Petazzoni wrote:
> Hello,
> 
> In the title: used -> use
> 
> On Fri,  1 Jul 2016 18:29:13 +0200, Samuel Martin wrote:
> 
>>  # Languages supported by the cross-compiler
>>  GCC_FINAL_CROSS_LANGUAGES-y = c
>>  GCC_FINAL_CROSS_LANGUAGES-$(BR2_INSTALL_LIBSTDCPP) += c++
>> -GCC_FINAL_CROSS_LANGUAGES-$(BR2_TOOLCHAIN_BUILDROOT_FORTRAN) += fortran
>> +GCC_FINAL_CROSS_LANGUAGES-$(BR2_TOOLCHAIN_HAS_FORTRAN) += fortran
> 
> I am not actually sure of the value of this change, and I would rather
> suggest that BR2_TOOLCHAIN_BUILDROOT_CXX should be used to enable the
> C++ support.
> 
> To me, BR2_TOOLCHAIN_BUILDROOT_CXX and BR2_TOOLCHAIN_BUILDROOT_FORTRAN
> indicate that you *want* C++/Fortran support in the gcc being built by
> Buildroot. Those config options are from gcc, and affect the gcc build.
> 
> On the other hand BR2_INSTALL_LIBSTDCPP (which should be named
> BR2_TOOLCHAIN_HAS_CXX) and BR2_TOOLCHAIN_HAS_FORTRAN should be used by
> *consumers* that need C++ or Fortran.
> 
> So I would be inclined to reject this patch.

 I agree.

 BTW, we actually can easily change BR2_INSTALL_LIBSTDCPP into
BR2_TOOLCHAIN_HAS_CXX because it's a blind symbol.

 BR2_TOOLCHAIN_BUILDROOT_CXX _should_ actually be named BR2_PACKAGE_GCC_CXX, but
that's more difficult because it's not blind.

 Regards,
 Arnout

> 
> Thomas
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list