[Buildroot] [PATCH v2 12/15] toolchain/toolchain-external: add knob for fortran support

[Samuel Martin]

On Fri, Jul 1, 2016 at 11:23 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Fri,  1 Jul 2016 18:29:17 +0200, Samuel Martin wrote:
>
>> +config BR2_TOOLCHAIN_EXTERNAL_FORTRAN
>> +     bool "Toolchain has Fortran support?"
>> +     depends on BR2_USE_WCHAR # libquadmath
>
> Is this dependency really needed? Plus libquadmath is only needed on
> i386/x86_64, so on other architectures, we could have Fortran support
> without wchar, could we?
Right, it should be:
  depends on (wchar && (i386 || x86_64)) || !(i386 || x86_64)

>
>> +     select BR2_TOOLCHAIN_HAS_FORTRAN
>> +     help
>> +       Select this option if your external toolchain has fortran
>> +       support. If you don't know, leave the default value,
>> +       Buildroot will tell you if it's correct or not.
>> +
>> +comment "Fortran support needs a toolchain w/ wchar"
>> +     depends on !BR2_USE_WCHAR
>
> I think this comment is not needed.
Indeed, if the external toolchain has fortran, then it already meets
all the fortran dependencies.

>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Samuel