[Buildroot] [PATCH v2 08/15] package/gcc: used BR2_TOOLCHAIN_HAS_FORTRAN instead of BR2_TOOLCHAIN_BUILDROOT_FORTRAN
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Jul 1 21:06:23 UTC 2016
Hello,
In the title: used -> use
On Fri, 1 Jul 2016 18:29:13 +0200, Samuel Martin wrote:
> # Languages supported by the cross-compiler
> GCC_FINAL_CROSS_LANGUAGES-y = c
> GCC_FINAL_CROSS_LANGUAGES-$(BR2_INSTALL_LIBSTDCPP) += c++
> -GCC_FINAL_CROSS_LANGUAGES-$(BR2_TOOLCHAIN_BUILDROOT_FORTRAN) += fortran
> +GCC_FINAL_CROSS_LANGUAGES-$(BR2_TOOLCHAIN_HAS_FORTRAN) += fortran
I am not actually sure of the value of this change, and I would rather
suggest that BR2_TOOLCHAIN_BUILDROOT_CXX should be used to enable the
C++ support.
To me, BR2_TOOLCHAIN_BUILDROOT_CXX and BR2_TOOLCHAIN_BUILDROOT_FORTRAN
indicate that you *want* C++/Fortran support in the gcc being built by
Buildroot. Those config options are from gcc, and affect the gcc build.
On the other hand BR2_INSTALL_LIBSTDCPP (which should be named
BR2_TOOLCHAIN_HAS_CXX) and BR2_TOOLCHAIN_HAS_FORTRAN should be used by
*consumers* that need C++ or Fortran.
So I would be inclined to reject this patch.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list