[Buildroot] [PATCH 07/21] pulseaudio: remove BR2_ARCH_HAS_ATOMICS dependency

[Yann E. MORIN]

Thomas, All,

On 2016-01-27 22:56 +0100, Thomas Petazzoni spake thusly:
> On Mon, 25 Jan 2016 19:52:38 +0100, Yann E. MORIN wrote:
> > >  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE
> > >  	depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
> > >  	depends on BR2_USE_MMU # pulseaudio
> > > -	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio
> > >  	depends on !BR2_STATIC_LIBS # pulseaudio
> > >  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c
> > >  	select BR2_PACKAGE_PULSEAUDIO
> > > @@ -212,7 +211,7 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE
> > >  
> > >  comment "pulseaudio support needs a toolchain w/ threads, dynamic library"
> > >  	depends on BR2_USE_MMU
> > > -	depends on BR2_ARCH_HAS_ATOMICS
> > > +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> > 
> > In retrospect, I think this dependency should be added in the previous
> > patch.
> > 
> > Yes, BR2_ARCH_HAS_ATOMICS is a superset of BR2_TOOLCHAIN_HAS_SYNC_4,
> > still it would be more logical to add it at the time the depednency on
> > _SYNC_4 is added.
> > 
> > Ditto for all comments, of course.
> 
> I intentionally kept the json-c and pulseaudio patches separate. The
> json-c patch only adds the additional BR2_TOOLCHAIN_HAS_SYNC_4
> dependency to json-c and all its reverse dependencies, keeping the
> BR2_ARCH_HAS_ATOMICS when they existed.
> 
> This patch then removes the BR2_ARCH_HAS_ATOMICS where they are no
> longer needed.
> 
> I think it remains bisectable, and allows to kept the patches somewhat
> saner in size than the cairo one.

Sorry, what I meant was that the 'depends on BR2_TOOLCHAIN_HAS_SYNC_4'
on the comment should have been added in the previous commit, i.e. at
the time json-c gains the _SYNC_4 dependency.

Then in this very commit, you can indeed 'just' remove the _HAS_ATOMICS
dependency.

> > > +# Make sure we don't detect libatomic_ops. Indeed, since pulseaudio
> > > +# requires json-c, which needs 4 bytes __sync builtins, there should
> > > +# be no need for pulseaudio to rely on libatomic_ops.
> > > +PULSE_AUDIO_CONF_ENV += \
> > > +	ac_cv_header_atomic_ops_h=no
> > 
> > What happens if pulseaudio detects libatomic_ops? Is it "bad" or just
> > merely "harmless"?
> 
> I don't think it's bad, but since it's not needed (as explained in the
> comment), I prefer to be sure that it doesn't get detected/used if
> libatomic_ops happens to be built before.

Yes, perfectly valid. It was just an inquiry out of curiosity.

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'