[Buildroot] [PATCH v2 1/3] graph-depends: fix handling of "virtual" in exclude_list
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Jan 27 20:32:13 UTC 2016
The condition to determine if a virtual package should be excluded
from the list due to "virtual" being passed in --exclude is under a
loop iterating over each entry of the exclude_list, but it doesn't use
the iterator of this list.
Indeed, the condition contains:
"virtual" in exclude_list
which checks automatically if "virtual" was passed in the list. Due to
this, there is no need for this check to be within the "for p in
exclude_list" iteration. This commit fixes that by moving the check
outside of the loop.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
---
support/scripts/graph-depends | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index fd8ad2f..cfb4f82 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -359,15 +359,14 @@ def print_pkg_deps(depth, pkg):
return
if max_depth == 0 or depth < max_depth:
for d in dict_deps[pkg]:
+ if dict_version.get(d) == "virtual" \
+ and "virtual" in exclude_list:
+ continue
add = True
for p in exclude_list:
if fnmatch(d,p):
add = False
break
- if dict_version.get(d) == "virtual" \
- and "virtual" in exclude_list:
- add = False
- break
if add:
print("%s -> %s" % (pkg_node_name(pkg), pkg_node_name(d)))
print_pkg_deps(depth+1, d)
--
2.6.4
More information about the buildroot
mailing list