[Buildroot] [RFC 2/2] remove download suppression from mke2img and skeleton

Arnout Vandecappelle arnout at mind.be
Mon Jan 25 00:16:16 UTC 2016


On 20-01-16 15:14, Thomas De Schampheleire wrote:
> On Tue, Jan 19, 2016 at 11:33 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>> Alex, All,
>>
>> On 2015-10-01 00:13 +0300, Alex Suykov spake thusly:
>>> With non-versioned packages patch applied, there is no need
>>> to set empty _SOURCE.
>>>
>>> Signed-off-by: Alex Suykov <alex.suykov at gmail.com>
>>
>> After the previous patch has been applied:
>>
>> Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
[snip]
>>> -# source included in buildroot
>>> -SKELETON_SOURCE =
>>> -
>>>  # The skeleton can't depend on the toolchain, since all packages depends on the
>>>  # skeleton and the toolchain is a target package, as is skeleton.
>>>  # Hence, skeleton would depends on the toolchain and the toolchain would depend
>>
> 
> Question is whether it is correct that mke2img and skeleton are unversioned.
> Packages that are similar are makedevs, mkpasswd and getent, where the
> _VERSION is explicitly set to match the Buildroot version:
> MAKEDEVS_VERSION = buildroot-$(BR2_VERSION)
> I think that mke2img is in the same boat as these packages, and so
> should follow the same strategy.

 +1 to that.

 Alex, will you send a v2 that sets the version of mke2img and skeleton to
buildroot-$(BR2_VERSION) instead?


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list