[Buildroot] [PATCH v2 2/2] docs/manual: patches that change files with spaces in the name

Ricardo Martincoski ricardo.martincoski at gmail.com
Sat Jan 23 23:53:43 UTC 2016


When a patch changes one or more files with spaces in the name, a
workaround must be applied to ensure the build using old versions of
+patch+ in the host system.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998 at free.fr>
---
v1 -> v2:
 - update the manual entry
 - use 1 or 2 hooks to rename the file that contains spaces
   (based on the suggestion to use a symlink from Thomas DS)
 - change the patch file to be applied on the renamed file

Symlink and hard link cannot be used because patch unlinks them.
So I renamed the file before patching it.
The file can be renamed back when needed.

Probably this patch will need some rewording.
It's my first patch to the manual.
I tested using 'make manual-html'
---
 docs/manual/patch-policy.txt | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/docs/manual/patch-policy.txt b/docs/manual/patch-policy.txt
index 0b4604e..471ded5 100644
--- a/docs/manual/patch-policy.txt
+++ b/docs/manual/patch-policy.txt
@@ -134,6 +134,23 @@ AC_PROG_MAKE_SET
 +AM_CONDITIONAL([CXX_WORKS], [test "x$rw_cv_prog_cxx_works" = "xyes"])
 ---------------
 
+==== Patches that change files with spaces in the name
+
+When a patch changes one or more files with spaces in the name, a workaround
+must be applied to ensure the build using old versions of +patch+ in the
+host system.
+
+. Add a hook to +<packagename>_POST_EXTRACT_HOOKS+ that renames the file to be
+  patched, replacing spaces with underscores;
+
+. Create the patch using the usual diff command, but both
+  +package-version.orig/+ and +package-version/+ must have the file renamed
+  to replace the spaces with underscores;
+
+. If the file must keep its name, add a hook to
+  +<packagename>_POST_PATCH_HOOKS+ that renames the patched file to its
+  original name;
+
 === Integrating patches found on the Web
 
 When integrating a patch of which you are not the author, you have to
-- 
1.9.1



More information about the buildroot mailing list