[Buildroot] [PATCH v10 4/4] toolchain-external: create symlink ARCH_LIB_DIR->lib

[Thomas De Schampheleire]

On Wed, Jan 20, 2016 at 4:24 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Thomas De Schampheleire,
>
> On Wed, 20 Jan 2016 16:09:07 +0100, Thomas De Schampheleire wrote:
>
>> +       ARCH_LIB_DIR="$(call toolchain_find_libdir,$(TOOLCHAIN_EXTERNAL_CC) $(TOOLCHAIN_EXTERNAL_CFLAGS))" ; \
>> +       if [ "$${ARCH_LIB_DIR}" != "lib" -a "$${ARCH_LIB_DIR}" != "$(SKELETON_LIB_SYMLINK)" ]; then \
>
> Where is SKELETON_LIB_SYMLINK defined? Shouldn't this be
> TOOLCHAIN_LIB_SYMLINK ?

This is indeed an error.

>
> Or better, can we indeed name the variable SKELETON_LIB_SYMLINK, have
> it under skeleton.mk, and replace this test by something that simply
> tests if ARCH_LIB_DIR exists or not. If it exists (i.e it's the lib/
> directory, or one of the lib32/ or lib64/ symlinks), there is nothing
> to do, otherwise you need to create the symlinks.

Yes, that can be done, I will resubmit.
Thanks for your feedback,
Thomas