[Buildroot] [PATCH v5] toolchain: allow side by side sysroot directories

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jan 19 22:14:39 UTC 2016


Dear Vicente Olivert Riera,

On Tue, 12 Jan 2016 17:49:38 +0000, Vicente Olivert Riera wrote:
> Currently our toolchain infrastructure assumes that every toolchain has
> nested sysroot directories. However that's not true for all of them. The
> Codescape toolchains from Imagination Technologies use a side by side
> sysroot structure, for instance.
> 
> This patch allows our toolchain infrastructure to detect what kind of
> sysroot structure we have (nested or side by side) and performs the
> appropriate actions.
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> Reviewed-by: Romain Naour <romain.naour at gmail.com>
> ---
> Changes v4 -> v5:
>  - Add an echo to display what is being symlinked. (Suggested by Romain)
> Changes v1 -> v4:
>  - This patch didn't exist before. It has been introduced in v4.

I've applied after updating the comment above the function to explain
what's going on. It's a pity we can't have inline comments in those big
shell blocks. Part of my mid-term goal is to move some of this crap to
helper shell scripts, which would simplify the syntax and allow the
addition of comments everywhere.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list