[Buildroot] [RFC PATCH v2 1/4] package/dhcp: bump version to 4.3.3

[Ricardo Martincoski]

Hi Doug and Arnout,

On Sun, 10 Jan 2016 15:25:06 -0600, Doug Kehn wrote:
> The embedded bind configure is called as part of dhcp make instead of
> dhcp configure. dhcp make environment is expanded to ensure bind
> configure has the proper information.
Maybe the bind configure could be called in a post configure hook.
This way, bind would be configured in the configure step too.

[snip]
> +DHCP_MAKE=$(MAKE1)
> +
> +DHCP_MAKE_ENV = \
> +	GNU_TARGET_NAME=$(GNU_TARGET_NAME) \
For at least one external toolchain, the bind configure can't find the
target compiler because it is expecting arm-buildroot-linux-gnueabi-gcc
while the binary name is arm-none-linux-gnueabi-gcc.
Maybe setting CC here would fix this.
> +	GNU_HOST_NAME=$(GNU_HOST_NAME) \
> +	AR="$(TARGET_AR)" \
> +	BUILD_CC="$(HOSTCC)"

If a hook is used, TARGET_CONFIGURE_OPTS can provide most of variables needed,
fixing the issue with some external toolchains.
Something like this:
DHCP_BIND_CONF_ENV = \
	$(TARGET_CONFIGURE_OPTS) \
	GNU_TARGET_NAME=$(GNU_TARGET_NAME) \
	GNU_HOST_NAME=$(GNU_HOST_NAME) \
	BUILD_CC="$(HOSTCC)"

define DHCP_CONFIGURE_BIND
	$(DHCP_BIND_CONF_ENV) $(DHCP_MAKE) -C $(@D)/bind bind1
endef
DHCP_POST_CONFIGURE_HOOKS += DHCP_CONFIGURE_BIND
> +
> +define DHCP_EXTRACT_BIND
> +	cd $(@D)/bind; tar -xvf bind.tar.gz
> +endef
> +DHCP_POST_EXTRACT_HOOKS += DHCP_EXTRACT_BIND

What do you think about this?

Regards,
Ricardo