[Buildroot] [PATCH] libnss: add build workaround for older gcc versions

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Jan 6 14:54:44 UTC 2016


Hello,

On Wed,  6 Jan 2016 11:18:54 -0300, Gustavo Zacarias wrote:
> nss uses some #pragma directives that require newish (>= 4.6) versions
> of gcc, so disable Werror when building with older versions to avoid the
> build from breaking unfairly.
> However make this a gcc >= 4.8 conditional since the kludge is called so
> (NSS_NO_GCC48) and other bits might depend upon it.

Here you say the kludge is called NSS_NO_GCC48, but...

> +# #pragma usage needs gcc >= 4.8
> +# See https://bugzilla.mozilla.org/show_bug.cgi?id=1226179
> +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_4_8),)
> +LIBNSS_BUILD_VARS += NSS_ENABLE_WERROR=0
> +endif

here you use NSS_ENABLE_WERROR.

Is it me misunderstanding your commit message?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list