[Buildroot] [PATCH 1/1] Added OK/FAIL output to SNMP init script.

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Feb 25 09:46:43 UTC 2016


Dear Andreas Ehmanns,

On Wed, 24 Feb 2016 18:31:21 +0100, Andreas Ehmanns wrote:
> Signed-off-by: Andreas Ehmanns <universeII at gmx.de>
> ---
>  package/netsnmp/S59snmpd | 98 +++++++++++++++++++++++++++---------------------
>  1 file changed, 56 insertions(+), 42 deletions(-)

While your patch looks OK, it is doing *much* more than "adding
OK/FAIL" as your commit title indicates.

Ideally, you should separate your changes into multiple patches to make
it easier to review the changes (like one patch to change to use
functions, one patch to add OK/FAIL, one patch to remove set -e, etc.).
Or at least, write a commit log that details all the changes that are
being done.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list