[Buildroot] [PATCH] owfs: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Feb 22 22:37:19 UTC 2016


Arnout,

On Mon, 22 Feb 2016 21:36:59 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:

> diff --git a/package/owfs/0001-configure.ac-check-for-localtime_r.patch b/package/owfs/0001-configure.ac-check-for-localtime_r.patch
> new file mode 100644
> index 0000000..bdaab4f
> --- /dev/null
> +++ b/package/owfs/0001-configure.ac-check-for-localtime_r.patch
> @@ -0,0 +1,48 @@
> +From dd7c906a7e548ccb7b9c101221531d6b203f701f Mon Sep 17 00:00:00 2001
> +From: "Arnout Vandecappelle (Essensium/Mind)" <arnout at mind.be>
> +Date: Sun, 21 Feb 2016 17:02:06 +0100
> +Subject: [PATCH] configure.ac: check for localtime_r
> +
> +HAVE_LOCALTIME_R is used in module/owftpd/src/c/file_list.c, so it
> +should be checked for.
> +
> +Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> +---
> + configure.ac                   | 2 +-
> + module/swig/python/setup.py.in | 7 -------
> + 2 files changed, 1 insertion(+), 8 deletions(-)

Your description explains perfectly well the change in configure.ac,
but does not explain the change done in setup.py.in. Shouldn't it be
part of a separate patch, with a proper description ?

The rest of the patch looks good.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list