[Buildroot] [PATCH v2 10/18] erlang-p1_stun: bump to version 0.9.0

Frank Hunleth fhunleth at troodon-software.com
Sun Feb 21 22:16:15 UTC 2016


Hi Thomas,

On Sat, Feb 20, 2016 at 6:12 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Sat, 20 Feb 2016 18:09:20 -0500, Frank Hunleth wrote:
>
>> Yes, I generally have the same preference. In the Erlang world, the
>> style is to use underscores since module names can be represented as
>> atoms. In theory, you can quote atoms if you want them to have
>> hyphens, but it doesn't look pretty. In the end, I don't think that it
>> bothers me either way, so I'm happy to leave it as is.
>
> Ok, fine.
>
>> >>  config BR2_PACKAGE_ERLANG_P1_STUN
>> >> -     bool "erlang-p1-stun"
>> >> -     select BR2_PACKAGE_ERLANG_P1_TLS
>> >> +     bool "erlang-p1_stun"
>> >> +     select BR2_PACKAGE_ERLANG_FAST_TLS
>> >
>> > Build testing has shown that BR2_PACKAGE_ERLANG_FAST_TLS was not the
>> > proper dependency, and instead keeping BR2_PACKAGE_ERLANG_P1_TLS was
>> > the right solution. Could you double check why you switched to
>> > fast_tls ?
>>
>> This was a mistake on my part. I fixed it in a patch that I hadn't
>> sent to the list, so thanks for fixing that for me.
>
> So, is the fast_tls package still useful?

No. I'll send a patch that removes it.

Frank


More information about the buildroot mailing list